Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HentaiCB: Fix http404 popularMangaRequest & latestUpdatesRequest #6501

Merged
merged 2 commits into from
Dec 7, 2024
Merged

HentaiCB: Fix http404 popularMangaRequest & latestUpdatesRequest #6501

merged 2 commits into from
Dec 7, 2024

Conversation

dejavui
Copy link
Contributor

@dejavui dejavui commented Dec 6, 2024 •
edited
Loading

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@vetleledaal
Copy link
Contributor

Why not just remove mangaSubString, so it defaults to manga?

@vetleledaal vetleledaal merged commit facf215 into keiyoushi:main Dec 7, 2024
23 checks passed
@dejavui dejavui deleted the fix-hentaicb branch December 8, 2024 07:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vetleledaal vetleledaal vetleledaal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dejavui @vetleledaal