Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merlin Scans and Nox Scans updated #5879

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

Forza06
Copy link
Contributor

@Forza06 Forza06 commented Nov 4, 2024

Closes#4917
Closes#5175

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

Copy link
Contributor

@AwkwardPeak7 AwkwardPeak7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also lint failed

Comment on lines 23 to 24
private const val VERIFICATION_ERROR = "Bölümü görüntülemek için WebView'de doğrulama yapmanız gerekiyor"
private const val ROBOT_VERIFICATION_ERROR = "Robot doğrulaması gerekiyor. WebView'de doğrulama yapın"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline these

Comment on lines 108 to 116
val responseBody = response.body.string()
val document = Jsoup.parse(responseBody)
checkVerification(document, response.request.url.toString())

val newResponse = response.newBuilder()
.body(responseBody.toResponseBody(response.body.contentType()))
.build()

return super.mangaDetailsParse(newResponse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above here

@AwkwardPeak7 AwkwardPeak7 merged commit 74b1612 into keiyoushi:main Nov 7, 2024
23 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants