Updating controller-runtime and dependencies #740
Conversation
…ons. Remove the use of operatorConfig (since it was removed from controller-runtime) and replace the controller-runtime parameters as cmd line options. Remove kube_rbac module for metrics authentication as it was deprecated also, instead replace it with the option of using secured metrics. Move serverconfig related stuff out from the apis and move them to the serverconfig pkg. This is part of the cleanup of external dependencies from apis package.
…move cert-manager annotation injections to webhook component, fix some Kustomize 5.x deprecations
… cluster deployment the default for "make deploy"
…r structure in kubebuilder and make it its own struct and not part of CassandraDatacenter object. This removes controller-runtime dependency from the apis.
…e replacements will not work correctly for Certificates
…rator installation
| - op: add | ||
| path: /spec/template/spec/containers/0/args/0 | ||
| value: --metrics-bind-address=:8443 |
There was a problem hiding this comment.
Question: I assume we'll need to do this in the helm charts as well?
There was a problem hiding this comment.
Yes, the Helm chart will require changes as well.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright 2021. | |||
| Copyright 2024 Just Me. | |||
| // Note that you must have the required binaries setup under the bin directory to perform | ||
| // the tests directly. When we run make test it will be setup and used automatically. | ||
| BinaryAssetsDirectory: filepath.Join("..", "..", "..", "bin", "k8s", | ||
| fmt.Sprintf("1.31.0-%s-%s", runtime.GOOS, runtime.GOARCH)), |
There was a problem hiding this comment.
Suggestion: could we make that version a variable? I'm worried that this is quite hidden in the code.
There was a problem hiding this comment.
Well, I can put it to the start of the file, but this isn't used for normal envtest runs - only if running from vscode directly.
| @@ -1,12 +1,37 @@ | |||
| --- | |||
| apiVersion: admissionregistration.k8s.io/v1 | |||
| kind: MutatingWebhookConfiguration | |||
There was a problem hiding this comment.
Question: why is a mutating webhook introduced?
There was a problem hiding this comment.
Well, actually we always had the feature, but if you tried to use it, it wouldn't work. This is for the DefaultingWebhook that was always present.
What this PR does:
Which issue(s) this PR fixes:
Fixes #718
Fixes #527
Fixes #617
Checklist