Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced obsolete JEP-12 with JEP-12-01. #138

Merged
merged 32 commits into from
Jan 17, 2023
Merged

Replaced obsolete JEP-12 with JEP-12-01. #138

merged 32 commits into from
Jan 17, 2023

Conversation

springcomp
Copy link
Contributor

Addresses #133.

@springcomp springcomp changed the title Replace obsolete JEP-12 with JEP-12-01. Replaced obsolete JEP-12 with JEP-12-01. Nov 19, 2022
@springcomp
Copy link
Contributor Author

@gibson042 for your consideration.

gibson042
gibson042 reviewed Nov 19, 2022
View reviewed changes
jep-012-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
gibson042
gibson042 suggested changes Dec 20, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012-01-raw-string-literals.md Outdated Show resolved Hide resolved
springcomp and others added 16 commits December 29, 2022 11:16
@springcomp
Formatted JSON strings using double-quotes consistently.
67fa017
@springcomp @gibson042
Improved wording around embedded backslash preservations.
ef03aa6 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp @gibson042
Fixed incorrect reference to grammar rule.
6833c06 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp @gibson042
Legacy syntax is officially deprecated and MUST be updated.
6067981 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp @gibson042
Legacy syntax is definitely deprecated.
3e2502e 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp @gibson042
Clarify literal rule more explicitly.
c0eee63 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp @gibson042
Deprecated means forbidden.
49a0abf 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp
Consistently formatted JSON strings using double-quotes.
32424ec
@springcomp
Finally reverted to representing abstract strings with “ and ” curly …
550f6ee 
…quotes.
@springcomp
Improved wording.
582cd88
@springcomp @gibson042
Updated requirements for JEP-12 specific tests.
8750aeb 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp @gibson042
Renamed grammar rules.
50efdaf 
Co-authored-by: Richard Gibson <[email protected]>
@springcomp
Renamed addendum for better lexicographical sorting.
0df3ad2
@springcomp
Explained JEP# amendment letter sequence.
c395e30
@springcomp
Renamed and re-authored JEP-12a.
f21b33e
@springcomp
Addressed further feedback from review.
56324a3
@springcomp springcomp requested a review from gibson042 January 11, 2023 20:12
gibson042
gibson042 suggested changes Jan 12, 2023
View reviewed changes
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
jep-012a-raw-string-literals.md Outdated Show resolved Hide resolved
springcomp and others added 8 commits January 12, 2023 08:08
@springcomp
Copy link
Contributor Author

@gibson042

Thank you very much for putting up with me and doing such an extensive review.
This is much appreciated.

I think we’re there now 🤞.

gibson042
gibson042 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we’re there now 🤞.

I think so too!

@springcomp springcomp merged commit cd5bbb2 into main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@springcomp @gibson042