Fixes

jet · Dec 6, 2021 · e300a63 · e300a63
1 parent 0191776
commit e300a63
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/Propulsion.Cosmos/CosmosPruner.fs b/src/Propulsion.Cosmos/CosmosPruner.fs
@@ -44,7 +44,7 @@ module Pruner =
                 totalDeferred <- totalDeferred + deferred
 
         /// Used to render exceptions that don't fall into the rate-limiting or timed-out categories
-        override _.HandleExn(log, exn) =
+        override _.HandleExn(log, _stream, exn) =
             match classify exn with
             | ExceptionKind.RateLimited | ExceptionKind.TimedOut ->
                 () // Outcomes are already included in the statistics - no logging is warranted

diff --git a/src/Propulsion.CosmosStore/CosmosStorePruner.fs b/src/Propulsion.CosmosStore/CosmosStorePruner.fs
@@ -42,7 +42,7 @@ module Pruner =
                 totalDeferred <- totalDeferred + deferred
 
         /// Used to render exceptions that don't fall into the rate-limiting or timed-out categories
-        override _.HandleExn(log, exn) =
+        override _.HandleExn(log, _stream, exn) =
             match classify exn with
             | ExceptionKind.RateLimited | ExceptionKind.TimedOut ->
                 () // Outcomes are already included in the statistics - no logging is warranted

diff --git a/src/Propulsion/Streams.fs b/src/Propulsion/Streams.fs
@@ -998,9 +998,9 @@ type Stats<'Outcome>(log : ILogger, statsInterval, statesInterval) =
             exnEvents <- exnEvents + es
             exnBytes <- exnBytes + int64 bs
             resultExnOther <- resultExnOther + 1
-            this.HandleExn(log.ForContext("stream", stream).ForContext("events", es).ForContext("duration", duration), exn)
+            this.HandleExn(log.ForContext("stream", stream).ForContext("events", es).ForContext("duration", duration), stream, exn)
     abstract member HandleOk : outcome : 'Outcome -> unit
-    abstract member HandleExn : log : ILogger * exn : exn -> unit
+    abstract member HandleExn : log : ILogger * streamName : FsCodec.StreamName * exn : exn -> unit
 
 module Projector =
 

diff --git a/tests/Propulsion.Kafka.Integration/ConsumersIntegration.fs b/tests/Propulsion.Kafka.Integration/ConsumersIntegration.fs
@@ -120,7 +120,7 @@ module Helpers =
         inherit Propulsion.Streams.Stats<unit>(log, statsInterval, stateInterval)
 
         override _.HandleOk(()) = ()
-        override _.HandleExn(log, exn) = log.Information(exn, "Unhandled")
+        override _.HandleExn(log, _stream, exn) = log.Information(exn, "Unhandled")
 
     let runConsumersBatch log (config : KafkaConsumerConfig) (numConsumers : int) (timeout : TimeSpan option) (handler : ConsumerCallback) = async {
         let mkConsumer (consumerId : int) = async {

diff --git a/tools/Propulsion.Tool/Program.fs b/tools/Propulsion.Tool/Program.fs
@@ -162,7 +162,7 @@ type Stats(log, statsInterval, statesInterval) =
     inherit Propulsion.Streams.Stats<unit>(log, statsInterval=statsInterval, statesInterval=statesInterval)
     member val StatsInterval = statsInterval
     override _.HandleOk(_log) = ()
-    override _.HandleExn(_log, _exn) = ()
+    override _.HandleExn(_log, _stream, _exn) = ()
 
 [<EntryPoint>]
 let main argv =