Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Add step to wrap the OTEL context and mask the credentials #206

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 7, 2021

🚧

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

This step provides a wrapper to bind the OTEL environment variables and mask any credentials such as the one provided in OTEL_EXPORTER_OTLP_HEADERS.

A similar step can be seen done in the shared library -> https://github.com/elastic/apm-pipeline-library/blob/master/vars/withOtelEnv.groovy

Rationale

Avoid exposing any sensitive credentials with some Masked support

Questions

Tasks

  • Finish the implementation
  • Define the signature
  • Add UTs

@v1v v1v added enhancement New feature or request question Further information is requested labels Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant