This repository has been archived by the owner on Mar 25, 2018. It is now read-only.
cloudstack: adding support for create volume from a custom disk offering #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adrian Cole » jclouds #1145 SUCCESS |
|
lgtm - though I'm a bit confused as to why there's this and #1464 - which one's the right one? |
|
This one is a request to pull the change into the jclouds 1.6.x branch (1.6.0-SNAPSHOT), the other one (#1464) is into master (1.7.0-SNAPSHOT). |
|
Aaaah, I'm dumb and didn't look at the branches. Mea culpa. =) |
|
Revise this according to the other PR, and in the future, get the first PR reviewed first before submitting a cherrypick. This leads to confusion for reviewers. |
|
Adrian Cole » jclouds #1165 SUCCESS |
|
jclouds-java-7-pull-requests #319 SUCCESS |
|
+1 I'll merge both in an hour unless folks object |
codefromthecrypt
pushed a commit
that referenced
this pull request
Apr 4, 2013
cloudstack: adding support for create volume from a custom disk offering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #1463