use three ifs instead of switch case and use else if to prevent from …

…creating more than one plan type
jaybxyz · Jul 28, 2021 · 132026e · 132026e
1 parent 1dea61b
commit 132026e
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/x/farming/keeper/proposal_handler.go b/x/farming/keeper/proposal_handler.go
@@ -13,21 +13,22 @@ func HandlePublicPlanProposal(ctx sdk.Context, k Keeper, proposal *types.PublicP
 		return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, err.Error())
 	}
 
-	switch {
-	case proposal.AddRequestProposals != nil:
+	if proposal.AddRequestProposals != nil {
 		if err := k.AddPublicPlanProposal(ctx, proposal.AddRequestProposals); err != nil {
 			return err
 		}
-	case proposal.UpdateRequestProposals != nil:
+	}
+
+	if proposal.UpdateRequestProposals != nil {
 		if err := k.UpdatePublicPlanProposal(ctx, proposal.UpdateRequestProposals); err != nil {
 			return err
 		}
-	case proposal.DeleteRequestProposals != nil:
+	}
+
+	if proposal.DeleteRequestProposals != nil {
 		if err := k.DeletePublicPlanProposal(ctx, proposal.DeleteRequestProposals); err != nil {
 			return err
 		}
-	default:
-		return sdkerrors.Wrapf(sdkerrors.ErrUnknownRequest, "unexpected public plan proposal %s", proposal.String())
 	}
 
 	return nil
@@ -58,9 +59,8 @@ func (k Keeper) AddPublicPlanProposal(ctx sdk.Context, proposals []*types.AddReq
 
 			logger := k.Logger(ctx)
 			logger.Info("created public fixed amount plan", "fixed_amount_plan", plan)
-		}
 
-		if !p.EpochRatio.IsZero() && !p.EpochRatio.IsNil() && !p.EpochRatio.IsNegative() {
+		} else if !p.EpochRatio.IsZero() && !p.EpochRatio.IsNil() && !p.EpochRatio.IsNegative() {
 			msg := types.NewMsgCreateRatioPlan(
 				p.GetName(),
 				farmingPoolAddrAcc,