Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask shape bug fix #358

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Conversation

pattonw
Copy link
Contributor

@pattonw pattonw commented Jan 2, 2025

Fix two bugs:

  1. The mask was not being processed appropriately for saving into the snapshot array
  2. The prepare_ds method was getting the offset passed in voxels, not physical units

Both related to the errors seen in #357

@mzouink
Copy link
Member

mzouink commented Jan 2, 2025

is this ready to merge? ( tests are failing )

@pattonw
Copy link
Contributor Author

pattonw commented Jan 2, 2025

Yes ready to merge

@mzouink mzouink merged commit e9f255c into janelia-cellmap:main Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants