Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Timeout #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding Timeout #2

wants to merge 1 commit into from

Conversation

Wachu985
Copy link

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Wachu985
Copy link
Author

I propose to add timeout to the methods to give the user more control of the timeout

Copy link
Owner

@jadolg jadolg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Wachu985 thank you so much for your contribution.
I'd like to change a couple of details though.
I'd like to have the default set to None instead of 60 since it's requests default value and tu use it as a named parameter on the calls because it's better to read and maintain.

@Wachu985
Copy link
Author

Wachu985 commented Aug 21, 2022

Yea it's a perfect idea

Hi @Wachu985 thank you so much for your contribution. I'd like to change a couple of details though. I'd like to have the default set to None instead of 60 since it's requests default value and tu use it as a named parameter on the calls because it's better to read and maintain.

@Loganche Loganche mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants