Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framebuffer #1

Open
wants to merge 82 commits into
base: 4.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
7ca8527
template for framebuffer highgui
kozinove Apr 2, 2024
fbafa76
add imshow
kozinove Apr 16, 2024
462a0e0
temporary implementation of waitKey
kozinove Apr 16, 2024
30da285
add if for bits_per_pixel and apply dos2unix
kozinove Apr 17, 2024
b9efae6
fix call mmap for FB
kozinove Apr 18, 2024
516f2a6
add x_offset
kozinove Apr 18, 2024
b1cfb7c
comment temp code
kozinove Apr 18, 2024
d54fad6
fix arrow event add delay support
kozinove Apr 19, 2024
78b8be6
fix create FB location and multiwindows support
kozinove May 6, 2024
49468ff
fix name
kozinove May 6, 2024
fb1b36b
code refactoring: renaming variables, stdout -> OpenCV LOG system
kozinove May 8, 2024
e3c702a
add env varibale for FB dev
kozinove May 8, 2024
9b54898
imp. log
kozinove May 8, 2024
346a301
Added conditions for FB format. Added image reformatting functionality
kozinove May 8, 2024
e7e0a29
fix test
kozinove May 12, 2024
439581b
add Window flags support. add gs format for img. fix register FB name.
kozinove May 20, 2024
ee0b70a
add FB mode
kozinove May 20, 2024
7a2f830
fix warning
kozinove May 20, 2024
9ad906c
add XVFB mode support
kozinove May 21, 2024
ceed483
fix style
kozinove May 21, 2024
1fef6a5
fix error FB mode
kozinove May 23, 2024
8c457ae
comment added. destructor fixed
kozinove May 24, 2024
e5b3871
fixed handling of window processing flags
kozinove May 24, 2024
b3a1b6d
fix WINDOW_AUTOSIZE
kozinove May 24, 2024
5339c26
fix show size
kozinove May 24, 2024
6194366
fixed some bugs and comments
kozinove May 27, 2024
5b85c52
The window display algorithm has been replaced. several bugs fixed
kozinove May 28, 2024
7b3cadb
fix style
kozinove May 28, 2024
2c8d797
fix trailing whitespace.
kozinove May 28, 2024
a29ebab
fix trailing whitespace.
kozinove May 28, 2024
1a8e00f
fix trailing whitespace.
kozinove May 28, 2024
35a6c9c
template for framebuffer highgui
kozinove Apr 2, 2024
872594d
add imshow
kozinove Apr 16, 2024
b241ef0
temporary implementation of waitKey
kozinove Apr 16, 2024
d5cce2a
add if for bits_per_pixel and apply dos2unix
kozinove Apr 17, 2024
e9d15c8
fix call mmap for FB
kozinove Apr 18, 2024
b9377cd
add x_offset
kozinove Apr 18, 2024
293872d
comment temp code
kozinove Apr 18, 2024
c6055b6
fix arrow event add delay support
kozinove Apr 19, 2024
6cc910d
fix create FB location and multiwindows support
kozinove May 6, 2024
a9a8b7a
fix name
kozinove May 6, 2024
5164ffc
code refactoring: renaming variables, stdout -> OpenCV LOG system
kozinove May 8, 2024
d5d80bc
add env varibale for FB dev
kozinove May 8, 2024
4c2d2e6
imp. log
kozinove May 8, 2024
6706b8a
Added conditions for FB format. Added image reformatting functionality
kozinove May 8, 2024
7d48035
fix test
kozinove May 12, 2024
741bbff
add Window flags support. add gs format for img. fix register FB name.
kozinove May 20, 2024
66cc5a1
add FB mode
kozinove May 20, 2024
c110050
fix warning
kozinove May 20, 2024
6aa4d40
add XVFB mode support
kozinove May 21, 2024
c353065
fix style
kozinove May 21, 2024
01f95fa
fix error FB mode
kozinove May 23, 2024
43aa713
comment added. destructor fixed
kozinove May 24, 2024
81afac4
fixed handling of window processing flags
kozinove May 24, 2024
c0bc02f
fix WINDOW_AUTOSIZE
kozinove May 24, 2024
9f0dccd
fix show size
kozinove May 24, 2024
6531b75
fixed some bugs and comments
kozinove May 27, 2024
db848a7
The window display algorithm has been replaced. several bugs fixed
kozinove May 28, 2024
bbf5874
fix style
kozinove May 28, 2024
ba5828d
fix trailing whitespace.
kozinove May 28, 2024
48f5ec7
fix trailing whitespace.
kozinove May 28, 2024
dc98bd1
fix trailing whitespace.
kozinove May 28, 2024
92b3a84
added getName method for FB
kozinove Jun 4, 2024
11dff94
merge
kozinove Jun 4, 2024
ff8b9d9
fix code style
kozinove Jun 4, 2024
afdb448
fix status of OPENCV_HIGHGUI_BUILTIN_BACKEND
kozinove Jun 4, 2024
08ba3f2
offset bug fixed
kozinove Jun 5, 2024
2e9cbf6
fix style
kozinove Jun 5, 2024
fb01d3b
fix coding style
kozinove Jun 10, 2024
875f439
redundant code removed
kozinove Jun 11, 2024
9b4f16d
fixes in cmake option
kozinove Jun 11, 2024
3a61f33
some comments corrected
kozinove Jun 12, 2024
8ece6be
Indentation in namespaces has been fixed.
kozinove Jun 12, 2024
3a63f85
comparison fixed
kozinove Jun 12, 2024
2972dff
removal of XWD dependency
kozinove Jun 14, 2024
dabbb5f
fixed trailing whitespace
kozinove Jun 14, 2024
757160b
fixed CMake files for framebuffer
kozinove Jun 19, 2024
7b41776
delete set for OPENCV_HIGHGUI_BUILTIN_BACKEND at detect_framebuffer.c…
kozinove Jun 19, 2024
0de5a51
fixed trailing whitespace~
kozinove Jun 19, 2024
6c5d2dc
fixed some comments
kozinove Jun 19, 2024
2b99518
fixed work with framebuffer in cmake
kozinove Jun 24, 2024
6bf5fcf
review comments have been corrected
kozinove Jun 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/highgui/src/window_framebuffer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ namespace cv { namespace highgui_backend {
{
CV_LOG_ERROR(NULL, "UI: Image type "
<< cv::typeToString(image.type()) << " is not supported" );
return;
}
break;
case 3:
Expand Down
9 changes: 7 additions & 2 deletions modules/highgui/test/test_gui.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ TEST(Highgui_GUI, regression)

EXPECT_NO_THROW(destroyAllWindows());
ASSERT_NO_THROW(namedWindow(window_name));
#if defined HAVE_FRAMEBUFFER
ASSERT_NO_THROW(resizeWindow(window_name, 800, 600));
#endif
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is correct in terms of OpenCV logic. Without resizing the window, the window and image sizes are not the same.

const vector<int> channels = {1, 3, 4};
const vector<int> depths = {CV_8U, CV_8S, CV_16U, CV_16S, CV_32F, CV_64F};
for(int cn : channels)
Expand Down Expand Up @@ -138,7 +141,8 @@ static void Foo(int, void* counter)
&& !defined HAVE_WIN32UI \
&& !defined HAVE_WAYLAND \
) \
|| defined(__APPLE__) // test fails on Mac (cocoa)
|| defined(__APPLE__) /* test fails on Mac (cocoa) */ \
|| defined HAVE_FRAMEBUFFER /* trackbar is not supported */
TEST(Highgui_GUI, DISABLED_trackbar_unsafe)
#else
TEST(Highgui_GUI, trackbar_unsafe)
Expand Down Expand Up @@ -178,7 +182,8 @@ void testTrackbarCallback(int pos, void* param)
&& !defined HAVE_WIN32UI \
&& !defined HAVE_WAYLAND \
) \
|| defined(__APPLE__) // test fails on Mac (cocoa)
|| defined(__APPLE__) /* test fails on Mac (cocoa) */ \
|| defined HAVE_FRAMEBUFFER /* trackbar is not supported */
TEST(Highgui_GUI, DISABLED_trackbar)
#else
TEST(Highgui_GUI, trackbar)
Expand Down