Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft updates 2 #6

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Draft updates 2 #6

wants to merge 12 commits into from

Conversation

Vectorized
Copy link
Collaborator

@Vectorized Vectorized commented Jan 17, 2025

  • ERC20 and native token spend permissions.

Todo:

  • Write tests.
  • EntryPoint create2 address.
  • Ability to let delegation approve more than one EntryPoint (tied to current delegation codehash). This allows for the delegation to possibly switch to a more performant, but abi equivalent EntryPoint in the future.

Thoughts:

  • The EntryPoint is quite a complex beast, due to it's need for gas introspection and performance, just like the 4337 EntryPoint. I think in the end state, a good EntryPoint will be written in very optimized inline-assembly. Also, the main bottleneck in Base's gas costs by far is L2 gas.

Copy link
Contributor

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about the AA folks exposing the validation logic in a separate function? Is it worth it?

I think there is a benefit because it'd let us build a Reth executor which prefetches session keys / verifies sigs in parallel, which could improve performance

I know it introduces the pre verification gas stuff which IMO should not be exposed to devs so I'd like to avoid that if we thought doing the validation / execution separation was worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants