Add info about query for files and wrap some lines #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
reviewed
Sep 29, 2021
docs/filelist.rst
Outdated
| Create `GoogleDriveFileList`_ instance with `parameters of Files.list()`_ as ``dict``. Call `GetList()`_ and you will get all files that matches your query as a list of `GoogleDriveFile`_. | ||
| Create `GoogleDriveFileList`_ instance with `parameters of Files.list()`_ as ``dict``. | ||
| Call `GetList()`_ and you will get all files that matches your query as a list of `GoogleDriveFile`_. | ||
| The syntax and possible option of the query ('q') parameter can be found in `search for files` Google documentation. |
There was a problem hiding this comment.
I mean backquotes or double backquotes to highlight it properly
shcheklein
reviewed
Sep 29, 2021
docs/filelist.rst
Outdated
| @@ -24,7 +26,9 @@ You can update metadata or content of these `GoogleDriveFile`_ instances if you | |||
| Paginate and iterate through files | |||
| ---------------------------------- | |||
|
|
|||
| *PyDrive* provides Pythonic way of paginating and iterating through list of files. All you have to do is to limit number of results with ``maxResults`` parameter and build ``for`` loop retrieving file list from API each iteration. | |||
| *PyDrive* provides Pythonic way of paginating and iterating through list of files. | |||
| All you have to do is to limit number of results with ``maxResults`` parameter and build ``for`` loop retrieving | |||
There was a problem hiding this comment.
Let's change the style a bit, please. Something like this should be better:
Here is an example how to do this, maxResults below defines how many files it retrieves at once and we wrap it into a for loop to iterate:
|
@shcheklein I've fixed the wording and resolved conflict |
shcheklein
approved these changes
Oct 4, 2021
|
thanks @tmotyl ! |
|
I'll release the new version of docs when/if we merge the #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.