Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automator: update istio@ test reference #16149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

istio-testing
Copy link
Contributor

@istio-testing istio-testing commented Jan 5, 2025

Generated by Automator - 2025-01-12T02:01:23+00:00

@istio-testing istio-testing requested a review from a team as a code owner January 5, 2025 02:02
@istio-testing istio-testing added release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2025
@craigbox
Copy link
Contributor

craigbox commented Jan 8, 2025

VERIFY FAILED snip_show_components (timeout after 120s):
received:
"NAME         	NAMESPACE   	REVISION	UPDATED                                	STATUS  	CHART        	APP VERSION
istio-ambient	istio-system	1       	2025-01-05 02:10:28.950082132 +0000 UTC	deployed	ambient-1.0.0	1.0.0"
expected:
"NAME            NAMESPACE       REVISION    UPDATED                                 STATUS      CHART           APP VERSION
istio-ambient      istio-system    1           2024-04-17 22:14:45.964722028 +0000 UTC deployed    ambient-1.25.0     1.25.0"

Error and context.

@bleggett Has the version of the all-in-one chart changed recently? Or could this be due to there not being a 1.25 published (I only see 1.24.x versions listed at https://artifacthub.io/packages/helm/istio-official/ambient)

@craigbox
Copy link
Contributor

craigbox commented Jan 8, 2025

/test doc.test.profile-none

@ericvn
Copy link
Contributor

ericvn commented Jan 9, 2025

The one test I looked at uses verify_like and that will fail as 1.0.0 is not 1.25.0. I didn't look to see what upstream change might have caused that change in output, nor if the test should be updated to take any value or a specific version.

@bleggett
Copy link
Contributor

bleggett commented Jan 9, 2025

@bleggett Has the version of the all-in-one chart changed recently? Or could this be due to there not being a 1.25 published (I only see 1.24.x versions listed at https://artifacthub.io/packages/helm/istio-official/ambient)

None of the other charts there have 1.25 versions either. rewrite_helm_repo is always rewriting all paths to use local manifest paths from the cloned istio repo anyway.

The version is set by/coming from the snip {{< istio_full_version >}} which is the same everywhere.

I'm not sure why the umbrella chart would be different, I can take a look.

@bleggett bleggett mentioned this pull request Jan 9, 2025
11 tasks
@bleggett
Copy link
Contributor

bleggett commented Jan 10, 2025

There's something else wrong, it's not related to the umbrella chart, the same problem is somehow happening with the other tests and the other charts:

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio.io/16149/doc.test.profile-none_istio.io/1876802141616607232/artifacts/tests-setup-profile-none-73eda8/TestDocs/ambient/install/helm/test.sh/test.sh/_test_context/test.sh_output.txt

The regular helm guide is also showing this error:

VERIFY FAILED snip_show_components (timeout after 120s):
received:
"NAME      	NAMESPACE   	REVISION	UPDATED                                	STATUS  	CHART        	APP VERSION
istio-base	istio-system	1       	2025-01-08 01:43:35.447951156 +0000 UTC	deployed	base-1.0.0   	1.0.0
istio-cni 	istio-system	1       	2025-01-08 01:43:44.558275262 +0000 UTC	deployed	cni-1.0.0    	1.0.0
istiod    	istio-system	1       	2025-01-08 01:43:39.594852026 +0000 UTC	deployed	istiod-1.0.0 	1.0.0
ztunnel   	istio-system	1       	2025-01-08 01:43:47.152889703 +0000 UTC	deployed	ztunnel-1.0.0	1.0.0"
expected:
"NAME            NAMESPACE       REVISION    UPDATED                                 STATUS      CHART           APP VERSION
istio-base      istio-system    1           2024-04-17 22:14:45.964722028 +0000 UTC deployed    base-1.25.0     1.25.0
istio-cni       istio-system    1           2024-04-17 22:14:45.964722028 +0000 UTC deployed    cni-1.25.0      1.25.0
istiod          istio-system    1           2024-04-17 22:14:45.964722028 +0000 UTC deployed    istiod-1.25.0   1.25.0
ztunnel         istio-system    1           2024-04-17 22:14:45.964722028 +0000 UTC deployed    ztunnel-1.25.0  1.25.0"

@istio-testing istio-testing force-pushed the none-master-automator-1313598d branch from ac37088 to c89da23 Compare January 12, 2025 02:02
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2025
@istio-testing
Copy link
Contributor Author

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile-minimal_istio.io c89da23 link true /test doc.test.profile-minimal
doc.test.profile-demo_istio.io c89da23 link true /test doc.test.profile-demo
doc.test.profile-default_istio.io c89da23 link true /test doc.test.profile-default
doc.test.dualstack_istio.io c89da23 link true /test doc.test.dualstack
doc.test.profile-ambient_istio.io c89da23 link true /test doc.test.profile-ambient
doc.test.profile-none_istio.io c89da23 link true /test doc.test.profile-none
doc.test.multicluster_istio.io c89da23 link true /test doc.test.multicluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants