Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PB-3627] Add encrypted kyber key to pwd change request #1420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[PB-3627] Add encrypted kyber key to pwd change request #1420

wants to merge 1 commit into from

Conversation

TamaraFinogina
Copy link
Contributor

Description

Re-encrypt and send Kyber key on password update, upgrade to SDK 1.9.3

Related Issues

Relates to PB-3627

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

Additional Notes

Backend changes are pending

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 4:42pm

@TamaraFinogina TamaraFinogina requested review from xabg2, sg-gs and CandelR and removed request for CandelR, xabg2 and sg-gs January 14, 2025 16:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TamaraFinogina TamaraFinogina mentioned this pull request Jan 14, 2025
Open
7 tasks
@TamaraFinogina TamaraFinogina self-assigned this Jan 15, 2025
@sg-gs
Copy link
Member

sg-gs commented Jan 15, 2025

Ensure this does not break something (although we are just upgrading 2 minors of the SDK with optional fields) @CandelR @xabg2

@TamaraFinogina TamaraFinogina requested a review from rafijv January 15, 2025 11:58
CandelR
CandelR approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test it I changed the password and had no problems, the rest of the features seem to work normally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabg2 xabg2 xabg2 approved these changes

@CandelR CandelR CandelR approved these changes

@sg-gs sg-gs sg-gs approved these changes

@rafijv rafijv rafijv approved these changes

Assignees

@TamaraFinogina TamaraFinogina

Labels
ready-for-preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TamaraFinogina @sg-gs @rafijv @CandelR @xabg2