[PB-3627] Send re-encrypted kyber key on pwd change #1418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
sg-gs
reviewed
Jan 14, 2025
| const privateKeyEncrypted = aes.encrypt(privateKey, newPassword, getAesInitFromEnv()); | ||
|
|
||
| const privateKyberKey = Buffer.from(user.keys.kyber.privateKey, 'base64').toString(); |
There was a problem hiding this comment.
As far as I currently know, if we are going to do this conditionally, we should be careful about Buffering or encrypting keys whose value is not sure to be present
TamaraFinogina
changed the base branch from
feature/PB-2666-implement-pqc
to
master
TamaraFinogina
changed the base branch from
master
to
feature/PB-2666-implement-pqc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-encrypt and send Kyber key on password update, upgrade to SDK 1.9.3
Related Issues
Relates to PB-3627
Related Pull Requests
Checklist
How Has This Been Tested?
Additional Notes
Backend changes are pending