Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated BDX groupings #158

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Updated BDX groupings #158

merged 1 commit into from
Mar 22, 2024

Conversation

calebbiggers
Copy link
Contributor

This PR fixes the consistency in grouping labels for BDX

edwarddavidbaker
edwarddavidbaker approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@edwarddavidbaker edwarddavidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per conversation today with Caleb and Weilin. Please ping Perry for final approval.

@calebbiggers calebbiggers merged commit 8df763c into main Mar 22, 2024
4 checks passed
@calebbiggers calebbiggers deleted the bdx-grouping-fix branch March 22, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1perrytaylor 1perrytaylor 1perrytaylor approved these changes

@edwarddavidbaker edwarddavidbaker edwarddavidbaker approved these changes

@kshiprab kshiprab Awaiting requested review from kshiprab kshiprab is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebbiggers @edwarddavidbaker @1perrytaylor