Add optional chaining to prevent history issue. #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've hit a strange bug where this particular line causes an issue after using `Inertia::location()` - it tries to read the `page` parameter of `window.history.state` which i'm assuming is reset during an Inertia::location() call? Adding the optional chaining modifier (as already exists in another reference to this variable further up the page) would fix this for us.
|
For context, we have an issue with the Svelte adapter,
I can't reproduce this in a very minimal reproduction repo - seems to work fine, but likely because i'm not passing large amounts of props around like we are in our production app. Hopefully this quick fix solves it for us without impacting any compatibility for any other adapters or the core as it's so small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've hit a strange bug where this particular line causes an issue after using
Inertia::location()- it tries to read thepageparameter ofwindow.history.statewhich i'm assuming is reset during an Inertia::location() call?Adding the optional chaining modifier (as already exists in another reference to this variable further up the page) would fix this for us.