Remove unused JavaScript #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amount of JavaScript cruft is too damn high. - Remove jquery.blockUI - The api `$.blockUI()` is not used anywhere in the app. - Remove linkify - The api `linkify()` is not used anywhere in the app. - Remvoe jquery.elastic - All textareas already have a width of 100% so they will adjust based on the browser window. - Remove jquery.easing - Nothing is using a custom easing function nor is the jquery defualt changed anywhere. - Remove jquery.qtip and styles - It's not loaded up in application.js nor are the CSS classes used anywhere. - Remove jquery.supersized - It's not loaded up in application.js nor are the CSS classes used anywhere. - Remove jquery.carouFredSel - It's not loaded up in application.js. - Remove script.js - No other JS references these functions. - Remove jquery.fancybox - There's nothing fancy going on here and it's not even loaded. - Remove jquery.ui - Nope, not used. - Remove jquery.min - ... we're using the jquery-rails gem already... - Moved JavaScript in the app layout from the body to the head. This isn't 2010 anymore. - Refactored most of the `main.js` code to not rely on jQuery. From what I can see, all the Holiday Social archive pages are each in their own self-contained folder under `public` and vendor their own JavaScript files (which probably also aren't used 90% of the time), but I left those alone.
t27duck
commented
May 21, 2023
| @@ -1,27 +1,56 @@ | |||
| $(document).ready(function() { | |||
| $('textarea').elastic(); | |||
| $('form.new_job_post_request, form.new_job, form.edit_job, #sign_in form').superLabels({ | |||
There was a problem hiding this comment.
Other than the jQuery version of Rails UJS, superlables is the only thing left from what I can tell that relies on jQuery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of JavaScript cruft is too damn high.
$.blockUI()is not used anywhere in the app.linkify()is not used anywhere in the app.main.jscode to not rely on jQuery.From what I can see, all the Holiday Social archive pages are each in their own self-contained folder under
publicand vendor their own JavaScript files (which probably also aren't used 90% of the time), but I left those alone.