Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .model.magpie, .project.justmip #274

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add .model.magpie, .project.justmip #274

wants to merge 2 commits into from

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jan 13, 2025

This PR adds (currently only placeholders for) two new modules:

  1. .model.magpie should contain generic code for setting up and parametrizing the linked MESSAGE-MAgPIE model combination.
  2. .project.justmip should contain code to use this generic capability in the way(s) required as part of the JustMIP project. Note that this module also may contain much other code related to the project, but for the present PR we only focus on separating out the usage from the capability w.r.t. MAgPIE.

These will eventually hold the files described in this Slack thread. Those files will be added in this and other PRs.

To complete:

  • Complete the JustMIP project description page.
  • Add the identified files.
  • Identify and set code owners for the added files/directories.

How to review

TBA

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.7%. Comparing base (dbd783e) to head (b51f015).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #274     +/-   ##
=======================================
- Coverage   77.6%   76.7%   -1.0%     
=======================================
  Files        211     211             
  Lines      16079   16079             
=======================================
- Hits       12481   12333    -148     
- Misses      3598    3746    +148     

see 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants