Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS Big Sur Dark/Light theme font/border color issue #248

Closed
wants to merge 1 commit into from
Closed

Fix MacOS Big Sur Dark/Light theme font/border color issue #248

wants to merge 1 commit into from

Conversation

MarlonJD
Copy link

@MarlonJD MarlonJD commented Dec 6, 2020

On light theme, there was an issue about the font color. On light theme black color is really bad on Big Sur.

Description

There was an issue about the font color when light theme was activated. So I changed font color and graph border color to white on light theme only on Big Sur.

So I changed these codes and I tested on my Mac.

Related Issue

Before:
image
After:
image

@ffreality
Copy link

such a nice fix !

@D0miH
Copy link
Member

D0miH commented Dec 7, 2020

Hey @MarlonJD,
thanks for contributing to the project.
However, please don't merge your master in our master.
Instead create a bug-fix-branch which is based on the current development branch as described here.

@MarlonJD
Copy link
Author

MarlonJD commented Dec 7, 2020

Okay than. I'll do this and create pull request again

@MarlonJD
Copy link
Author

MarlonJD commented Dec 7, 2020

I try to follow contributing rules. Please check #251

@MarlonJD MarlonJD closed this Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants