Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tick size for charts #533

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Change tick size for charts #533

merged 5 commits into from
Jan 14, 2025

Conversation

ethank2222
Copy link
Contributor

Description

Always 6 ticks, each tick size is calculated as the max table value divided by 6.

Screenshots

Begin:
image

End:
Screenshot 2024-12-06 191455

Steps to verify/test this change:

Look at chart for class availabilities

Final Checks:

Yes, I did

Issues

None

Closes #

Always 6 ticks, each tick size is calculated as the max table value divided by 6.
@ethank2222 ethank2222 temporarily deployed to staging-533 December 7, 2024 04:02 — with GitHub Actions Inactive
Copy link
Member

@Awesome-E Awesome-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check some of the repo files – it looks like this PR should just be changing the QuarterTooltip component, and not any dependencies

api/.env.example Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
site/src/component/QuarterTooltip/Chart.tsx Outdated Show resolved Hide resolved
@Awesome-E Awesome-E linked an issue Jan 6, 2025 that may be closed by this pull request
@Awesome-E Awesome-E temporarily deployed to staging-533 January 14, 2025 00:59 — with GitHub Actions Inactive
@ethank2222 ethank2222 temporarily deployed to staging-533 January 14, 2025 01:04 — with GitHub Actions Inactive
@ethank2222 ethank2222 temporarily deployed to staging-533 January 14, 2025 01:07 — with GitHub Actions Inactive
@ethank2222 ethank2222 merged commit 78c14ee into main Jan 14, 2025
2 checks passed
@ethank2222 ethank2222 deleted the tick-size-y-axis-charts branch January 14, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show an appropriate number of ticks on the y axis of charts
3 participants