-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added button to duplicate roadmap #532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem to work correctly, and code looks good! A couple things to note though:
- Transfers are separate from the roadmap so they're not really "copied" but rather it's just reading the same one. It does still work though
- I think it'd make more sense to have the duplicate button between the pencil and the trash can icons, because right now it's not clear (even with text) that "duplicate roadmap" refers to the current one (it may be confused as a button to open a selection menu). I don't know how technically difficult it would be to make it so that every roadmap can be duplicated easily, but I think it's worth exploring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, I agree with Ethan's 2nd point, and think if possible it should be implemented before merging with main. See AntAlmanac as an example.
Is it intended that duplicating "test (copy)" creates "test (copy) (copy)" instead of "test (copy 2)"? because if you duplicate "test" twice it's fine, but if you duplicate the copy, it does copy copy |
Yep as intended |
New button to duplicate currently selected roadmap.
Will copy the content of the selected roadmap and select the copy upon duplication.
Description
Screenshots
Before:
After:
Steps to verify/test this change:
Final Checks:
(optional)
Issues
Closes #519