static link with parasolid (winx64) (backport #954) [release/4.11.x] #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* static link with parasolid to prevent frustrum collisions when integrating with PP * change parasolid link for non-windows --------- Co-authored-by: Daniel Rodriguez <[email protected]> (cherry picked from commit a706ba4)
mergify
bot
requested review from
pmconne,
khanaffan,
calebmshafer and
bbastings
as code owners
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pmconne
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent frustrum collisions when integrating with other Apps. By statically linking on Windows, the addon will gets its own frustrum and copy of Parasolid functions to isolate itself from other Apps (when loaded in-process). This allows for greater interoperability when writing Connectors. As it stood today, Parasolid was always loaded when the addon initialized, so static linking should not have notable impact on loading and startup.
https://github.com/iTwin/imodel-native-internal/pull/721
This is an automatic backport of pull request #954 done by [Mergify](https://mergify.com).
imodel-native-internal: https://github.com/iTwin/imodel-native-internal/pull/727