Allow attach/detach db to IModelDb connection #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanaffan
requested review from
pmconne,
calebmshafer,
bbastings,
rschili,
ColinKerr and
nick4598
as code owners
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Had a teams chat with Affan, I asked what happens if the attached ECDb is incompatible, like a different profile or incompatible schemas. It seems the code is not robust in handling that. We should add some more tests and safeguards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
itwinjs-core: iTwin/itwinjs-core#7530
Allow attach/detach db to active connection. This allow to combine data from more then on db using ECSQL.
Note: ConcurrentQuery has been updated to support attach detach as well.
iTwin/itwinjs-core#7532