Trim whitespace of existing assignment and grouping titles #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
commented
Jul 29, 2024
| def upgrade() -> None: | ||
| conn = op.get_bind() | ||
|
|
||
| result = conn.execute( |
There was a problem hiding this comment.
| ) | ||
| print(f"Assignment titles updated: {result.rowcount}") | ||
|
|
||
| result = conn.execute( |
There was a problem hiding this comment.
| ) | ||
| print(f"Empty assignment titles: {result.rowcount}") | ||
|
|
||
| result = conn.execute( |
There was a problem hiding this comment.
|
For #6456 |
|
Could you add a description to the PR? |
My bad, had to many PRs and marked the wrong one ready for review. Added a bit more context now. |
acelaya
approved these changes
Jul 31, 2024
| sa.text( | ||
| """ | ||
| UPDATE assignment SET title = TRIM(title) | ||
| WHERE TRIM(title) != title; |
There was a problem hiding this comment.
Does this really make a difference? Couldn't we just get away with UPDATE assignment SET title = TRIM(title)?
There was a problem hiding this comment.
Yes, while the where makes the query slower it should lock less rows which should be safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #6472 we do the same in the python code, we trim new assignment and course titles. We also normalize empty (``) titles to null.
This PR does the same for existing titles in the DB with a DB migration.
Testing