Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alter schema on reverse edge after querying schema #55

Merged

Conversation

jairad26
Copy link
Member

@jairad26 jairad26 commented Jan 10, 2025

Description

On query of a type with a reverse edge, it modifies the type to remove all other predicates. The expected logic should only alter the schema if the type and predicate for the reverse edge does not exist.
Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo
    staged and linked here

@jairad26 jairad26 requested a review from a team as a code owner January 10, 2025 00:25
@jairad26 jairad26 changed the title Jai/hyp 2913 schema alteration on connected types is incorrect fix: alter schema on reverse edge after querying schema Jan 10, 2025
@jairad26 jairad26 enabled auto-merge (squash) January 10, 2025 00:27
@jairad26 jairad26 merged commit 42b1452 into main Jan 10, 2025
5 checks passed
@jairad26 jairad26 deleted the jai/hyp-2913-schema-alteration-on-connected-types-is-incorrect branch January 10, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants