-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Code review #53
base: pre-apis
Are you sure you want to change the base?
Changes from all commits
bb00fef
47fec90
208821a
571b799
0420655
a8aee3e
2e3b106
3e824e2
1116c7c
84b781b
f7007a4
fff8aaa
e676bc6
a157525
dac39a7
77effe0
2e7ac26
bcd42e1
dd2ea80
7abdc72
48b27de
205eaf7
f24f940
42b1452
b9226a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# CODEOWNERS info: https://help.github.com/en/articles/about-code-owners | ||
# Owners are automatically requested for review for PRs that changes code | ||
# that they own. | ||
|
||
* @hypermodeinc/database |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
--- | ||
name: Bug report | ||
about: Create a report to help us improve | ||
title: "" | ||
labels: bug | ||
assignees: "" | ||
--- | ||
|
||
**Describe the bug** A clear and concise description of what the bug is. | ||
|
||
**To Reproduce** Steps to reproduce the behavior: | ||
|
||
1. Go to '...' | ||
2. Click on '....' | ||
3. Scroll down to '....' | ||
4. See error | ||
|
||
**Expected behavior** A clear and concise description of what you expected to happen. | ||
|
||
**Screenshots** If applicable, add screenshots to help explain your problem. | ||
|
||
**Environment** | ||
|
||
- OS: [e.g. macOS, Windows, Ubuntu] | ||
- Language [e.g. Go] | ||
- Version [e.g. v0.xx] | ||
|
||
**Additional context** Add any other context about the problem here. | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
blank_issues_enabled: false | ||
contact_links: | ||
- name: Modus Community Support | ||
url: https://discord.hypermode.com | ||
about: Please ask and answer questions here |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
name: Feature request | ||
about: Suggest an idea for this project | ||
title: "" | ||
labels: "" | ||
assignees: "" | ||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** A clear and concise description | ||
of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** A clear and concise description of any alternative | ||
solutions or features you've considered. | ||
|
||
**Additional context** Add any other context or screenshots about the feature request here. | ||
Comment on lines
+9
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Trunk merged the title and body of these paragraphs, because they were just bold text rather than headings. Use |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
self-hosted-runner: | ||
# Labels of self-hosted runner in array of string | ||
labels: | ||
- warp-ubuntu-latest-arm64-2x | ||
- warp-ubuntu-latest-arm64-4x |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
**Description** | ||
|
||
Please explain the changes you made here. | ||
|
||
**Checklist** | ||
|
||
- [ ] Code compiles correctly and linting passes locally | ||
- [ ] For all _code_ changes, an entry added to the `CHANGELOG.md` file describing and linking to | ||
this PR | ||
- [ ] Tests added for new functionality, or regression tests for bug fixes added as applicable | ||
- [ ] For public APIs, new features, etc., PR on [docs repo](https://github.com/hypermodeinc/docs) | ||
staged and linked here | ||
|
||
**Instructions** | ||
|
||
- The PR title should follow the [Conventional Commits](https://www.conventionalcommits.org/) | ||
syntax, leading with `fix:`, `feat:`, `chore:`, `ci:`, etc. | ||
- The description should briefly explain what the PR is about. In the case of a bugfix, describe or | ||
link to the bug. | ||
- In the checklist section, check the boxes in that are applicable, using `[x]` syntax. | ||
- If not applicable, remove the entire line. Only leave the box unchecked if you intend to come | ||
back and check the box later. | ||
- Delete the `Instructions` line and everything below it, to indicate you have read and are | ||
following these instructions. 🙂 | ||
|
||
Thank you for your contribution to modusDB! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
{ | ||
"$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
"extends": [ | ||
"github>hypermodeinc/renovate-config" | ||
] | ||
"extends": ["github>hypermodeinc/renovate-config"] | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,35 @@ | ||||||
name: ci-go-lint | ||||||
|
||||||
on: | ||||||
pull_request: | ||||||
types: | ||||||
- opened | ||||||
- synchronize | ||||||
- reopened | ||||||
- ready_for_review | ||||||
paths: | ||||||
- "**/*.go" | ||||||
- "**/go.mod" | ||||||
- .github/workflows/* | ||||||
|
||||||
permissions: | ||||||
contents: read | ||||||
actions: write | ||||||
|
||||||
jobs: | ||||||
ci-go-lint: | ||||||
runs-on: warp-ubuntu-latest-arm64-2x | ||||||
|
||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
|
||||||
- name: Set up Go | ||||||
uses: actions/setup-go@v5 | ||||||
with: | ||||||
go-version-file: go.mod | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unfortunately, That means it will install the version from the So instead, configure manually and keep it updated.
Suggested change
|
||||||
cache-dependency-path: go.sum | ||||||
|
||||||
- name: golangci-lint | ||||||
uses: golangci/[email protected] | ||||||
with: | ||||||
args: --timeout=10m |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -8,30 +8,26 @@ on: | |||||
- reopened | ||||||
- ready_for_review | ||||||
paths: | ||||||
- '**/*.go' | ||||||
- '**/go.mod' | ||||||
- "**/*.go" | ||||||
- "**/go.mod" | ||||||
- .github/workflows/* | ||||||
|
||||||
permissions: | ||||||
contents: read | ||||||
actions: write | ||||||
|
||||||
jobs: | ||||||
ci-go-tests: | ||||||
runs-on: ubuntu-24.04 | ||||||
runs-on: warp-ubuntu-latest-arm64-4x | ||||||
|
||||||
steps: | ||||||
- uses: actions/checkout@v4 | ||||||
|
||||||
- name: Set up Go | ||||||
uses: actions/setup-go@v5 | ||||||
with: | ||||||
go-version-file: 'go.mod' | ||||||
go-version-file: go.mod | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
cache-dependency-path: go.sum | ||||||
|
||||||
- name: golangci-lint | ||||||
uses: golangci/[email protected] | ||||||
with: | ||||||
args: --timeout=10m | ||||||
|
||||||
- name: Run Unit Tests | ||||||
run: go test -race -v ./... |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,3 +17,5 @@ go.work.sum | |
|
||
# env file | ||
.env | ||
|
||
cpu_profile.prof |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
*out | ||
*logs | ||
*actions | ||
*notifications | ||
*tools | ||
plugins | ||
user_trunk.yaml | ||
user.yaml | ||
tmp |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"line-length": { "line_length": 150, "tables": false }, | ||
"no-inline-html": false, | ||
"no-bare-urls": false, | ||
"no-space-in-emphasis": false, | ||
"no-emphasis-as-heading": false, | ||
"first-line-heading": false | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"semi": false, | ||
"proseWrap": "always", | ||
"printWidth": 100 | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
rules: | ||
quoted-strings: | ||
required: only-when-needed | ||
extra-allowed: ["{|}"] | ||
key-duplicates: {} | ||
octal-values: | ||
forbid-implicit-octal: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# This file controls the behavior of Trunk: https://docs.trunk.io/cli | ||
# To learn more about the format of this file, see https://docs.trunk.io/reference/trunk-yaml | ||
|
||
version: 0.1 | ||
|
||
cli: | ||
version: 1.22.8 | ||
|
||
# Trunk provides extensibility via plugins. (https://docs.trunk.io/plugins) | ||
plugins: | ||
sources: | ||
- id: trunk | ||
ref: v1.6.6 | ||
uri: https://github.com/trunk-io/plugins | ||
|
||
# Many linters and tools depend on runtimes - configure them here. (https://docs.trunk.io/runtimes) | ||
runtimes: | ||
enabled: | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
|
||
# This is the section where you manage your linters. (https://docs.trunk.io/check/configuration) | ||
lint: | ||
enabled: | ||
- [email protected] | ||
- [email protected] | ||
- git-diff-check | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
|
||
actions: | ||
enabled: | ||
- trunk-announce | ||
- trunk-check-pre-push | ||
- trunk-fmt-pre-commit | ||
- trunk-upgrade-available |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"recommendations": ["trunk.io"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
{ | ||
"editor.formatOnSave": true, | ||
"editor.defaultFormatter": "trunk.io", | ||
"editor.trimAutoWhitespace": true, | ||
"trunk.autoInit": false | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# Changelog | ||
|
||
## UNRELEASED | ||
|
||
- feat: add readfrom json tag to support reverse edges | ||
[#49](https://github.com/hypermodeinc/modusDB/pull/49) | ||
|
||
- chore: Refactoring package management [#51](https://github.com/hypermodeinc/modusDB/pull/51) | ||
|
||
- fix: alter schema on reverse edge after querying schema | ||
[#55](https://github.com/hypermodeinc/modusDB/pull/55) | ||
|
||
## 2025-01-02 - Version 0.1.0 | ||
|
||
Baseline for the changelog. | ||
|
||
See git commit history for changes for this version and prior. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
# Contributor Covenant Code of Conduct | ||
|
||
## Our Pledge | ||
|
||
We as members, contributors, and leaders pledge to make participation in our community a | ||
harassment-free experience for everyone, regardless of age, body size, visible or invisible | ||
disability, ethnicity, sex characteristics, gender identity and expression, level of experience, | ||
education, socio-economic status, nationality, personal appearance, race, religion, or sexual | ||
identity and orientation. | ||
|
||
We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and | ||
healthy community. | ||
|
||
## Our Standards | ||
|
||
Examples of behavior that contributes to a positive environment for our community include: | ||
|
||
- Demonstrating empathy and kindness toward other people | ||
- Being respectful of differing opinions, viewpoints, and experiences | ||
- Giving and gracefully accepting constructive feedback | ||
- Accepting responsibility and apologizing to those affected by our mistakes, and learning from the | ||
experience | ||
- Focusing on what is best not just for us as individuals, but for the overall community | ||
|
||
Examples of unacceptable behavior include: | ||
|
||
- The use of sexualized language or imagery, and sexual attention or advances of any kind | ||
- Trolling, insulting or derogatory comments, and personal or political attacks | ||
- Public or private harassment | ||
- Publishing others' private information, such as a physical or email address, without their | ||
explicit permission | ||
- Other conduct which could reasonably be considered inappropriate in a professional setting | ||
|
||
## Enforcement Responsibilities | ||
|
||
Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior | ||
and will take appropriate and fair corrective action in response to any behavior that they deem | ||
inappropriate, threatening, offensive, or harmful. | ||
|
||
Community leaders have the right and responsibility to remove, edit, or reject comments, commits, | ||
code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and | ||
will communicate reasons for moderation decisions when appropriate. | ||
|
||
## Scope | ||
|
||
This Code of Conduct applies within all community spaces, and also applies when an individual is | ||
officially representing the community in public spaces. Examples of representing our community | ||
include using an official e-mail address, posting via an official social media account, or acting as | ||
an appointed representative at an online or offline event. | ||
|
||
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community | ||
leaders responsible for enforcement at [email protected]. All complaints will be reviewed and | ||
investigated promptly and fairly. | ||
|
||
All community leaders are obligated to respect the privacy and security of the reporter of any | ||
incident. | ||
|
||
## Enforcement Guidelines | ||
|
||
Community leaders will follow these Community Impact Guidelines in determining the consequences for | ||
any action they deem in violation of this Code of Conduct: | ||
|
||
### 1. Correction | ||
|
||
**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or | ||
unwelcome in the community. | ||
|
||
**Consequence**: A private, written warning from community leaders, providing clarity around the | ||
nature of the violation and an explanation of why the behavior was inappropriate. A public apology | ||
may be requested. | ||
|
||
### 2. Warning | ||
|
||
**Community Impact**: A violation through a single incident or series of actions. | ||
|
||
**Consequence**: A warning with consequences for continued behavior. No interaction with the people | ||
involved, including unsolicited interaction with those enforcing the Code of Conduct, for a | ||
specified period of time. This includes avoiding interactions in community spaces as well as | ||
external channels like social media. Violating these terms may lead to a temporary or permanent ban. | ||
|
||
### 3. Temporary Ban | ||
|
||
**Community Impact**: A serious violation of community standards, including sustained inappropriate | ||
behavior. | ||
|
||
**Consequence**: A temporary ban from any sort of interaction or public communication with the | ||
community for a specified period of time. No public or private interaction with the people involved, | ||
including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this | ||
period. Violating these terms may lead to a permanent ban. | ||
|
||
### 4. Permanent Ban | ||
|
||
**Community Impact**: Demonstrating a pattern of violation of community standards, including | ||
sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement | ||
of classes of individuals. | ||
|
||
**Consequence**: A permanent ban from any sort of public interaction within the community. | ||
|
||
## Attribution | ||
|
||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.0, available at | ||
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. | ||
|
||
Community Impact Guidelines were inspired by | ||
[Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity). | ||
|
||
[homepage]: https://www.contributor-covenant.org | ||
|
||
For answers to common questions about this code of conduct, see the FAQ at | ||
https://www.contributor-covenant.org/faq. Translations are available at | ||
https://www.contributor-covenant.org/translations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trunk merged the title and body of these paragraphs, because they were just bold text rather than headings. Use
##
headings instead.