fix: reimplement DynamicMap parsing #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JairusSW
changed the title
|
It's failing because it can't find |
mattjohnsonpint
changed the title
Yeah, don't worry about that for now. We'll fix that check soon. The rest are passing. |
mattjohnsonpint
approved these changes
Jan 6, 2025
JairusSW
deleted the
jairus/hyp-2850-function-parsejsontorawmap-needs-edition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #671
Wrote this new algorithm from the ground up to be fault-tolerant and handle whitespace correctly.
It's well-tested and will be a major improvement over the previous version.