Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce Go build times #615

Merged
merged 6 commits into from
Nov 26, 2024
Merged

fix: Reduce Go build times #615

merged 6 commits into from
Nov 26, 2024

Conversation

mattjohnsonpint
Copy link
Member

@mattjohnsonpint mattjohnsonpint commented Nov 26, 2024

Description

The Modus Go SDK has two compilation steps. This used to be required, but it turns out we've already addressed the cause of that and just hadn't removed the extra compilation. This PR removes the first pass, so there's just a single compile. Thus, build times are reduced significantly.

The PR also adds some diagnostic output, which is visible if MODUS_TRACE=true is set.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR

@mattjohnsonpint mattjohnsonpint requested a review from a team as a code owner November 26, 2024 00:54
@mattjohnsonpint mattjohnsonpint merged commit bf7630a into main Nov 26, 2024
57 checks passed
@mattjohnsonpint mattjohnsonpint deleted the mjp/hyp-2676-go-build branch November 26, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants