try without the new dep

hyperlane-xyz · Jun 27, 2024 · 4aca1e2 · 4aca1e2
1 parent 21080b8
commit 4aca1e2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 20 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/ethers-middleware/Cargo.toml b/ethers-middleware/Cargo.toml
@@ -27,7 +27,6 @@ serde = { version = "1.0.124", default-features = false, features = ["derive"] }
 thiserror = { version = "1.0", default-features = false }
 futures-util = { version = "^0.3" }
 futures-locks = { version = "0.7", default-features = false }
-futures-channel.workspace = "0.2.9"
 tracing = { version = "0.1.37", default-features = false }
 tracing-futures = { version = "0.2.5", default-features = false }
 

diff --git a/ethers-middleware/src/gas_escalator/mod.rs b/ethers-middleware/src/gas_escalator/mod.rs
@@ -6,7 +6,7 @@ pub use linear::LinearGasPrice;
 
 use async_trait::async_trait;
 
-use futures_channel::oneshot;
+// use futures_channel::oneshot;
 use futures_util::{lock::Mutex, select_biased};
 use instant::Instant;
 use std::{pin::Pin, sync::Arc};
@@ -60,7 +60,7 @@ pub(crate) struct GasEscalatorMiddlewareInternal<M> {
     /// The transactions which are currently being monitored for escalation
     #[allow(clippy::type_complexity)]
     pub txs: ToEscalate,
-    _background: oneshot::Sender<()>,
+    // _background: oneshot::Sender<()>,
 }
 
 /// A Gas escalator allows bumping transactions' gas price to avoid getting them
@@ -192,18 +192,18 @@ where
         E: GasEscalator + 'static,
         M: 'static,
     {
-        let (tx, rx) = oneshot::channel();
+        // let (tx, rx) = oneshot::channel();
         let inner = Arc::new(inner);
 
         let txs: ToEscalate = Default::default();
 
         let this = Arc::new(GasEscalatorMiddlewareInternal {
             inner: inner.clone(),
             txs: txs.clone(),
-            _background: tx,
+            // _background: tx,
         });
 
-        let esc = EscalationTask { inner, escalator, frequency, txs, shutdown: rx };
+        let esc = EscalationTask { inner, escalator, frequency, txs };
 
         {
             spawn(esc.escalate().instrument(tracing::debug_span!("gas-escalation")));
@@ -220,19 +220,13 @@ pub struct EscalationTask<M, E> {
     escalator: E,
     frequency: Frequency,
     txs: ToEscalate,
-    shutdown: oneshot::Receiver<()>,
+    // shutdown: oneshot::Receiver<()>,
 }
 
 #[cfg(not(target_arch = "wasm32"))]
 impl<M, E> EscalationTask<M, E> {
-    pub fn new(
-        inner: M,
-        escalator: E,
-        frequency: Frequency,
-        txs: ToEscalate,
-        shutdown: oneshot::Receiver<()>,
-    ) -> Self {
-        Self { inner, escalator, frequency, txs, shutdown }
+    pub fn new(inner: M, escalator: E, frequency: Frequency, txs: ToEscalate) -> Self {
+        Self { inner, escalator, frequency, txs }
     }
 
     async fn escalate(mut self) -> Result<(), GasEscalatorError<M>>
@@ -256,10 +250,6 @@ impl<M, E> EscalationTask<M, E> {
 
         loop {
             select_biased! {
-            _ = &mut self.shutdown => {
-                tracing::debug!("Shutting down escalation task, middleware has gone away");
-                return Ok(())
-            }
             opt = watcher.next() => {
                 if opt.is_none() {
                     tracing::error!("timing future has gone away");