feat: Reassign save search shortcut for Arc (#389)

hyperdxio · May 1, 2024 · ebd3f25 · ebd3f25
1 parent 148c92b
commit ebd3f25
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/.changeset/kind-moons-appear.md b/.changeset/kind-moons-appear.md
@@ -0,0 +1,5 @@
+---
+'@hyperdx/app': patch
+---
+
+Reassign save search shortcut for Arc to CMD+SHIFT+S
diff --git a/packages/app/src/LogTable.tsx b/packages/app/src/LogTable.tsx
@@ -577,10 +577,12 @@ export const RawLogTable = memo(
       [highlightedLineId, onRowExpandClick, dedupLogs],
     );
 
-    useHotkeys(['ArrowRight', 'j'], () => {
+    useHotkeys(['ArrowRight', 'ArrowDown', 'j'], e => {
+      e.preventDefault();
       shiftHighlightedLineId(1);
     });
-    useHotkeys(['ArrowLeft', 'k'], () => {
+    useHotkeys(['ArrowLeft', 'ArrowUp', 'k'], e => {
+      e.preventDefault();
       shiftHighlightedLineId(-1);
     });
 

diff --git a/packages/app/src/SearchPage.tsx b/packages/app/src/SearchPage.tsx
@@ -482,8 +482,15 @@ function SearchPage() {
     }
   }, [selectedSavedSearch, setSearchedQuery, _searchedQuery]);
 
+  const isArcBrowser =
+    typeof window !== 'undefined' &&
+    window
+      .getComputedStyle?.(document.documentElement)
+      .getPropertyValue('--arc-palette-title');
+
   useHotkeys(
-    ['ctrl+s', 'meta+s'],
+    // Arc Browser uses CMD+S for toggling sidebar which conflicts with save search
+    isArcBrowser ? ['ctrl+shift+s', 'meta+shift+s'] : ['ctrl+s', 'meta+s'],
     () => {
       setSaveSearchModalMode('save');
     },