Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gradient accumulation steps without using deepspeed #35745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

baoyf4244
Copy link

@baoyf4244 baoyf4244 commented Jan 17, 2025

What does this PR do?

when training without deepspeed, before loss backward, the loss is not scaling with gradient_accumulation_steps, this is caused by the parameter gradient_accumulation_steps not passed to Accelerator when creating this object.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try using main again, #35651 has fixed this.

In the future, the trainer explicitly does not rely on the Accelerator’s highest GA interface because it doesn’t account (easily) for the token nuances needed that Unsloth found. (We use the second/mid level API instead)

@baoyf4244
Copy link
Author

Ok, I'm sorry I have not find that issue a few days ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants