use torch constraints to check if covariance is positive definite during mean resizing. #35693
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuelnasr0
requested review from
Rocketknight1 and
ArthurZucker
as code owners
Rocketknight1
approved these changes
Jan 14, 2025
|
There's a CI issue that I can't fix with a retrigger, though - can you push an empty commit, or make a change and then revert it, to trigger the CI again? After that the tests should be green and we can merge |
abuelnasr0
force-pushed
the
fix_covariance_psd_check
branch
2 times, most recently
from
04fa5bc to
2dff84e
Compare
abuelnasr0
force-pushed
the
fix_covariance_psd_check
branch
from
2dff84e to
301f98c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this PR implements this solution #35075.
using torch constraints to check if the covariance is positive definite.
cc: @Rocketknight1