Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix low-precision audio classification pipeline #35435

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix low-precision audio classification pipeline #35435

wants to merge 11 commits into from

Conversation

jiqing-feng
Copy link
Contributor

@jiqing-feng jiqing-feng commented Dec 27, 2024 •
edited
Loading

Fix low-precision usage for audio-classification pipeline.

Require test

@LysandreJik
Copy link
Member

cc @eustlb

@jiqing-feng
Copy link
Contributor Author

jiqing-feng commented Jan 3, 2025 •
edited
Loading

Hi @LysandreJik @eustlb . The test is added, please run
RUN_SLOW=1 pytest ./tests/pipelines/test_pipelines_audio_classification.py::AudioClassificationPipelineTests::test_small_model_pt_fp16 -rsx -v
to check it. Thanks!

@jiqing-feng
add test
a47f5bd 
Signed-off-by: jiqing-feng <[email protected]>
@jiqing-feng
fix format
0d9d2e1 
Signed-off-by: jiqing-feng <[email protected]>
@jiqing-feng
fix torch import
19f4328 
Signed-off-by: jiqing-feng <[email protected]>
@jiqing-feng
fix torch import
35d4d6d 
Signed-off-by: jiqing-feng <[email protected]>
@jiqing-feng
fix format
b7954b0 
Signed-off-by: jiqing-feng <[email protected]>
@jiqing-feng
Merge branch 'main' into audio
ad11c95
@jiqing-feng
Copy link
Contributor Author

Waiting for review ....

@jiqing-feng
Copy link
Contributor Author

Hi @SunMarc , please review this PR, thanks!

SunMarc
SunMarc approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@SunMarc SunMarc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for adding this ! Accepted since the changes are similar to this PR : #20864

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunMarc SunMarc SunMarc approved these changes

@Rocketknight1 Rocketknight1 Awaiting requested review from Rocketknight1 Rocketknight1 is a code owner

@ArthurZucker ArthurZucker Awaiting requested review from ArthurZucker ArthurZucker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiqing-feng @LysandreJik @HuggingFaceDocBuilderDev @SunMarc