Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config defaults in the headless binary. #19336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hrydgard
Copy link
Owner

Fixes #19332

@hrydgard hrydgard added this to the v1.18.0 milestone Jul 17, 2024
@hrydgard
Copy link
Owner Author

As expected, some test didn't pass. But morph? What? :) will need to investigate.

@hrydgard
Copy link
Owner Author

Of course, locally it runs just fine :/ Hm.

@Nabile-Rahmani
Copy link
Contributor

Nabile-Rahmani commented Jul 18, 2024

It does fail locally for me.

testfailure:
__testfailure

testcompare:
__testcompare

Is it normal the resolutions differ ? Also the testcompare looks dithered, whereas the failure is solid. And well, there's more spacing too to the right.

Oh, looking at pspautotests, the expected image is testfailure (the smaller image), so the faulty output is called testcompare.

The expected dump is aligned to 512 pixels horizontally and not 480 pixels, explaining the spacing.

@hrydgard
Copy link
Owner Author

That is strange, it should be using softgpu which has a fixed resolution (the original).

Did you run on Linux? What command line did you use to run it?

@Nabile-Rahmani
Copy link
Contributor

Linux, yep.

The command is the one in CI: ./test.py -g --graphics=software

@hrydgard
Copy link
Owner Author

hrydgard commented Jul 18, 2024

ok, I tried on Windows and only ran the one test, using my usual command line:

--root pspautotests/tests/../ --compare --timeout=5 --graphics=software pspautotests/tests/gpu/vertices/morph.prx

I can indeed reproduce it in Linux (WSL2). So I'll go bisect it by only partially defaulting settings :)

This is enough:

build/PPSSPPHeadless --root pspautotests/tests/../ --compare --timeout=5 --graphics=software pspautotests/tests/gpu/vertices/morph.prx

@hrydgard hrydgard modified the milestones: v1.18.0, v1.19.0 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The headless testing environment does not load the default config
2 participants