-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use config defaults in the headless binary. #19336
base: master
Are you sure you want to change the base?
Conversation
As expected, some test didn't pass. But morph? What? :) will need to investigate. |
Of course, locally it runs just fine :/ Hm. |
It does fail locally for me. Is it normal the resolutions differ ? Also the testcompare looks dithered, whereas the failure is solid. And well, there's more spacing too to the right. Oh, looking at pspautotests, the expected image is testfailure (the smaller image), so the faulty output is called testcompare. The expected dump is aligned to 512 pixels horizontally and not 480 pixels, explaining the spacing. |
That is strange, it should be using softgpu which has a fixed resolution (the original). Did you run on Linux? What command line did you use to run it? |
Linux, yep. The command is the one in CI: |
ok, I tried on Windows and only ran the one test, using my usual command line:
I can indeed reproduce it in Linux (WSL2). So I'll go bisect it by only partially defaulting settings :) This is enough:
|
Fixes #19332