Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the nextjs example to use Yoga #762

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Rewrite the nextjs example to use Yoga #762

merged 2 commits into from
Jan 22, 2023

Conversation

neongreen
Copy link
Contributor

Fixes #761.

Sorry for the pnpm-lock.yaml noise, I used the same pnpm version as in package.yaml but it didn't help. Perhaps you can reset it and push the regenerated lockfile to my branch (assuming that it even matters).

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2023

⚠️ No Changeset found

Latest commit: 0d6e24f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
pothos ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 22, 2023 at 6:26AM (UTC)

@hayes
Copy link
Owner

hayes commented Jan 22, 2023

Lock file doesn't matter as long as tests pass, Pothos doesn't have any dependencies in published packages, so shouldn't be an issue

req: NextApiRequest;
res: NextApiResponse;
}>({
schema,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know not all existing examples have this, but all examples should have a context factory that at a minimum creates an empty context object. Some Pothos plugins require a context object, and it's good practice to set this up for any new graphql api

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree and I'll add a context factory

@hayes
Copy link
Owner

hayes commented Jan 22, 2023

Thanks for updating this!

@neongreen neongreen changed the title Rewrite the nextjs example to use helix Rewrite the nextjs example to use Yoga Jan 22, 2023
@hayes hayes merged commit f3df85b into hayes:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the Next.js example to use Yoga?
2 participants