-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the nextjs example to use Yoga #762
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lock file doesn't matter as long as tests pass, Pothos doesn't have any dependencies in published packages, so shouldn't be an issue |
req: NextApiRequest; | ||
res: NextApiResponse; | ||
}>({ | ||
schema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know not all existing examples have this, but all examples should have a context factory that at a minimum creates an empty context object. Some Pothos plugins require a context object, and it's good practice to set this up for any new graphql api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree and I'll add a context factory
Thanks for updating this! |
Fixes #761.
Sorry for the pnpm-lock.yaml noise, I used the same pnpm version as in
package.yaml
but it didn't help. Perhaps you can reset it and push the regenerated lockfile to my branch (assuming that it even matters).