Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Apply input padding ~and color tweaks~ #1281

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

414owen
Copy link
Contributor

@414owen 414owen commented Jan 3, 2024

This adds some padding to inputs, giving them a bit of a sense of space.

  • input background: light grey
  • text input background: light purple

I think the padding makes the inputs considerably less cramped, but style is subjective, so any input is welcome.

Are there any other pages with inputs that might have changed? If so, let me know and I'll screenshot the differences.

Before

Firefox - dark theme

Screenshot from 2024-01-03 12-45-22
Screenshot from 2024-01-03 13-14-24
Screenshot from 2024-01-03 13-16-30

Chromium - light theme

Screenshot from 2024-01-03 12-58-03
Screenshot from 2024-01-03 13-14-00
Screenshot from 2024-01-03 13-16-48

After

Firefox - dark theme

Screenshot from 2024-01-03 12-45-10
Screenshot from 2024-01-03 13-14-12
Screenshot from 2024-01-03 13-16-21

Chromium - light theme

Screenshot from 2024-01-03 12-57-53
Screenshot from 2024-01-03 13-13-53
Screenshot from 2024-01-03 13-16-42

@peterbecich
Copy link
Member

Looks good to me, thanks! But I am not a reviewer

@ysangkok
Copy link
Member

ysangkok commented Jan 22, 2024

Thanks for taking the time to improve Hackage.

I'd prefer to not change the form input background color in the light theme. Seeing the pink hue, I'd interpret as meaning something, while it seems like it actually means nothing. White input elements are common around the web, red hues are usually used when validation failed. I'd be curious to hear others on this too.

I don't like the white input elements on the dark theme though, there is too much contrast. I'd prefer if we just started out fixing that issue first. (I'd suggest making them just slightly brighter than the background)

I don't mind the padding, though.

@peterbecich
Copy link
Member

good point @ysangkok about the pink hue, I hadn't thought of that.

@414owen , would you remove the color changes or split into a different PR and keep the other improvements in this PR?

This adds some padding to inputs, giving them
a bit of a sense of space.
@414owen 414owen force-pushed the os/input-padding-and-colour branch from 216ce65 to d9ed57d Compare June 24, 2024 21:59
@414owen
Copy link
Contributor Author

414owen commented Jun 24, 2024

@peterbecich Sure thing, I've removed the purple tinge from the text inputs :)

Screenshot 2024-06-24 at 22 57 28

@peterbecich
Copy link
Member

@ysangkok please review

@414owen 414owen changed the title style: Apply input padding and color tweaks style: Apply input padding ~and color tweaks~ Jun 25, 2024
@ysangkok ysangkok merged commit 7b34592 into haskell:master Jun 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants