Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OneSignal.php #208

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Update OneSignal.php #208

merged 1 commit into from
Aug 22, 2024

Conversation

guibranco
Copy link
Owner

No description provided.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2024
Copy link

deepsource-io bot commented Aug 22, 2024

Here's the code health analysis summary for commits a52b6cc..5962870. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource SQL LogoSQL✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource PHP LogoPHP✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePhp
Branch Coverage100%100%
Composite Coverage95.8% (up 0.1% from main)95.8% (up 0.1% from main)
Line Coverage95.8% (up 0.1% from main)95.8% (up 0.1% from main)

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

Infisical secrets check: ✅ No secrets leaked!

Scan results:

10:33PM INF scanning for exposed secrets...
10:33PM INF 142 commits scanned.
10:33PM INF scan completed in 431ms
10:33PM INF no leaks found

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a52b6cc) 235 225 95.74%
Head commit (5962870) 236 (+1) 226 (+1) 95.76% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#208) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (a52b6cc) to head (5962870).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files           8        8           
  Lines         230      230           
=======================================
  Hits          220      220           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guibranco guibranco enabled auto-merge (squash) August 22, 2024 22:34
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Aug 22, 2024
@guibranco guibranco merged commit 51a917f into main Aug 22, 2024
30 checks passed
@guibranco guibranco deleted the guibranco-patch-2 branch August 22, 2024 22:34
$userAgentHeader = "User-Agent: $customUserAgent";
}
$this->headers = [$userAgentHeader, "Content-Type: application/json; charset=utf-8", "Authorization: Basic " . $token];
$this->headers = array(

Check warning

Code scanning / Phpcs (reported by Codacy)

Short array syntax must be used to define arrays Warning

Short array syntax must be used to define arrays
}
$this->headers = [$userAgentHeader, "Content-Type: application/json; charset=utf-8", "Authorization: Basic " . $token];
$this->headers = array(
"User-Agent: " . ($customUserAgent ?? "Pancake/0.8 (+https://github.com/guibranco/pancake)"),

Check warning

Code scanning / Phpcs (reported by Codacy)

Array value not aligned correctly; expected 26 spaces but found 12 Warning

Array value not aligned correctly; expected 26 spaces but found 12
}
$this->headers = [$userAgentHeader, "Content-Type: application/json; charset=utf-8", "Authorization: Basic " . $token];
$this->headers = array(
"User-Agent: " . ($customUserAgent ?? "Pancake/0.8 (+https://github.com/guibranco/pancake)"),

Check warning

Code scanning / Phpcs (reported by Codacy)

Concat operator must not be surrounded by spaces Warning

Concat operator must not be surrounded by spaces
$this->headers = [$userAgentHeader, "Content-Type: application/json; charset=utf-8", "Authorization: Basic " . $token];
$this->headers = array(
"User-Agent: " . ($customUserAgent ?? "Pancake/0.8 (+https://github.com/guibranco/pancake)"),
"Content-Type: application/json; charset=utf-8",

Check warning

Code scanning / Phpcs (reported by Codacy)

Array value not aligned correctly; expected 26 spaces but found 12 Warning

Array value not aligned correctly; expected 26 spaces but found 12
$this->headers = array(
"User-Agent: " . ($customUserAgent ?? "Pancake/0.8 (+https://github.com/guibranco/pancake)"),
"Content-Type: application/json; charset=utf-8",
"Authorization: Basic " . $token

Check warning

Code scanning / Phpcs (reported by Codacy)

Comma required after last value in array declaration Warning

Comma required after last value in array declaration
$this->headers = array(
"User-Agent: " . ($customUserAgent ?? "Pancake/0.8 (+https://github.com/guibranco/pancake)"),
"Content-Type: application/json; charset=utf-8",
"Authorization: Basic " . $token

Check warning

Code scanning / Phpcs (reported by Codacy)

Concat operator must not be surrounded by spaces Warning

Concat operator must not be surrounded by spaces
"User-Agent: " . ($customUserAgent ?? "Pancake/0.8 (+https://github.com/guibranco/pancake)"),
"Content-Type: application/json; charset=utf-8",
"Authorization: Basic " . $token
);

Check warning

Code scanning / Phpcs (reported by Codacy)

Closing parenthesis not aligned correctly; expected 25 spaces but found 8 Warning

Closing parenthesis not aligned correctly; expected 25 spaces but found 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant