Bump linter to 1.61.0 #1068
Merged
Bump linter to 1.61.0 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
==========================================
- Coverage 69.18% 67.89% -1.30%
==========================================
Files 110 110
Lines 7069 8656 +1587
==========================================
+ Hits 4891 5877 +986
- Misses 1888 2488 +600
- Partials 290 291 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ruben Vargas <[email protected]>
iblancasa
approved these changes
Oct 22, 2024
rubenvp8510
commented
Oct 22, 2024
| @@ -139,7 +139,7 @@ func (r *TempoStackReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| // | |||
| // - For any other error: Set the status condition to Failed, | |||
| // the Reason to "FailedReconciliation" and the message to the error message. | |||
| func (r *TempoStackReconciler) handleReconcileStatus(ctx context.Context, log logr.Logger, tempo v1alpha1.TempoStack, reconcileError error) (ctrl.Result, error) { | |||
There was a problem hiding this comment.
@iblancasa @andreasgerstmayr I a comment here to ignore this rule, but might need to change something here?
There was a problem hiding this comment.
I think ignoring the linter rule is fine, it's just complaining that the first return parameter is always ctrl.Result{}
andreasgerstmayr
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to bump the linter because old version got stuck in the actions. Not sure what changed, but bumping the version seems to work.