[loki-distributed] Add minAvailable poddisruptionbudget #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stafot
force-pushed
the
loki-add-pod-disruption-budgets-customized
branch
from
e16e389 to
1b83c11
Compare
stafot
changed the title
stafot
requested review from
torstenwalter,
zanhsieh and
a team
as code owners
stafot
force-pushed
the
loki-add-pod-disruption-budgets-customized
branch
2 times, most recently
from
980cfb4 to
0486999
Compare
|
Lint fails because |
Signed-off-by: Stavros Foteinopoulos <[email protected]>
Signed-off-by: Stavros Foteinopoulos <[email protected]> Update helm-docs Signed-off-by: Stavros Foteinopoulos <[email protected]>
stafot
force-pushed
the
loki-add-pod-disruption-budgets-customized
branch
from
61932aa to
784debd
Compare
zanhsieh
requested changes
Jan 17, 2025
| @@ -22,7 +22,7 @@ jobs: | |||
|
|
|||
| - name: Check Docs | |||
| run: | | |||
| docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.8.1 | |||
| docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.14.2 | |||
There was a problem hiding this comment.
This should be a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
In our use case we need to be able to customize
minAvailablevalue in podDisruptionBudgets.