[grafana] Added support for .spec.loadBalancerClass #2730
Conversation
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Sheikh-Abubaker
requested review from
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
Sheikh-Abubaker
changed the title
Signed-off-by: Sheikh-Abubaker <[email protected]>
There was a problem hiding this comment.
@Sheikh-Abubaker
Thanks for the contribution. Can you bump the version in Chart.yaml and fixing the lint-test error please?
I did bumped the version from 6.61.1 to 6.61.2 but that doesn't seem to have any effect and also about the lint-test error can you please guide me how to fix that error |
@Sheikh-Abubaker |
It does and I know the error is showing up due to the reason "[key-duplicates] duplication of key "type" in mapping" but my query is that we need to specify there config for two types of services "ClusterIP" and "LoadBalancer" so how do I do it with using "type" key twice ? I did researched about this but I am getting a bit confused there as I am really very new to Open source and doesn't know that much, but willing to learn |
Signed-off-by: Sheikh-Abubaker <[email protected]>
…into spec_branch
Hi @zanhsieh, I have fixed the error please check if everything is upto the mark. |
…into spec_branch
|
Hi @zanhsieh can you please look into this PR if this is upto to the mark, I'm not in any sort of hurry but have participated in Hacktoberfest and it's almost end of Hacktoberfest2023 and I've still got 2 more PRs to be merged in order to reach 4/4 PRs merged criteria, so just wanted to know. |
…into spec_branch
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
…empo-distributed Signed-off-by: Sheikh-Abubaker <[email protected]>
) * ci: update-helm-repo with Github Apps JWT Signed-off-by: Olha Yevtushenko <[email protected]> * ci: enhance update-helm-repo with Github Apps Signed-off-by: Olha Yevtushenko <[email protected]> --------- Signed-off-by: Olha Yevtushenko <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: verejoel <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Emil Kordahl <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Marton Schneider <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Mahdi <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
…empo-distributed Signed-off-by: Sheikh-Abubaker <[email protected]>
) * ci: update-helm-repo with Github Apps JWT Signed-off-by: Olha Yevtushenko <[email protected]> * ci: enhance update-helm-repo with Github Apps Signed-off-by: Olha Yevtushenko <[email protected]> --------- Signed-off-by: Olha Yevtushenko <[email protected]> Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
Signed-off-by: Sheikh-Abubaker <[email protected]>
…into spec_branch Signed-off-by: Sheikh-Abubaker <[email protected]>
…-charts into spec_branch Signed-off-by: Sheikh-Abubaker <[email protected]>
|
@zanhsieh, in order to keep this PR up to date with main branch I pushed some latest changes but due to some reason the lint test failed in this commit to fix the lint error I committed again but this time using GUI and I think that was the mistake I made from that point no matter how many time ran rebase the DCO check kept failing so I think I should close this PR and open a fresh one |
There was a problem hiding this comment.
@Sheikh-Abubaker
Can you sign DCO please?
https://github.com/grafana/helm-charts/pull/2730/checks?check_run_id=18089636060
@zanhsieh, Please check this new PR, I have fixed errors and also signed the DCO it's all done |
Issue #2717