-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Add the ability to add extraObjects #2722
Conversation
Signed-off-by: Sergey <[email protected]>
Signed-off-by: Sergey <[email protected]>
Signed-off-by: Sergey <[email protected]>
Thank your the PR. I'm wondering if there is another way you might achieve your goal. Since you are attempting to render any object here without referencing anything internally, it seems that could live anywhere in your deployment and doesn't necessarily need to live here, is that correct? Do we gain additional value by having this change as part of the helm chart? |
Similar manifests are used in many diagrams, for example, https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/extra-manifests.yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we do this in the other charts as well.
Add the ability to create extraObjects in helm chart.