Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Add the ability to add extraObjects #2722

Merged
merged 4 commits into from
Nov 25, 2023

Conversation

1Psy
Copy link
Contributor

@1Psy 1Psy commented Oct 18, 2023

Add the ability to create extraObjects in helm chart.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2023

CLA assistant check
All committers have signed the CLA.

@1Psy 1Psy requested a review from a team as a code owner October 18, 2023 17:35
@zalegrala
Copy link
Contributor

Thank your the PR. I'm wondering if there is another way you might achieve your goal. Since you are attempting to render any object here without referencing anything internally, it seems that could live anywhere in your deployment and doesn't necessarily need to live here, is that correct? Do we gain additional value by having this change as part of the helm chart?

@1Psy
Copy link
Contributor Author

1Psy commented Nov 15, 2023

Thank your the PR. I'm wondering if there is another way you might achieve your goal. Since you are attempting to render any object here without referencing anything internally, it seems that could live anywhere in your deployment and doesn't necessarily need to live here, is that correct? Do we gain additional value by having this change as part of the helm chart?

Similar manifests are used in many diagrams, for example, https://github.com/grafana/helm-charts/blob/main/charts/grafana/templates/extra-manifests.yaml.
In my opinion, this is normal practice.
For example, when declaring a VirtualService for Istio or when working with operator secrets.

Copy link
Contributor

@zalegrala zalegrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we do this in the other charts as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants