Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Move finalizers away from GetAllMatchingInstances #1821

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Fix: Move finalizers away from GetAllMatchingInstances #1821

merged 3 commits into from
Jan 14, 2025

Conversation

Baarsgaard
Copy link
Contributor

  • chore: Only fetch scoped matching instances in GrafanaFolder finalize
  • chore: Only fetch scoped matching instances in GrafanaNotificationTemplate finalize
  • chore: remove GetAllMatchingInstances and relevant tests

@Baarsgaard Baarsgaard changed the title Fix finalizer inconsistencies Fix: Move finalizers away from GetAllMatchingInstances Jan 13, 2025
@Baarsgaard Baarsgaard marked this pull request as ready for review January 13, 2025 23:37
@theSuess theSuess added this pull request to the merge queue Jan 14, 2025
Merged via the queue into grafana:master with commit 0ef4996 Jan 14, 2025
14 checks passed
@Baarsgaard Baarsgaard deleted the fix_finalizer_inconsistencies branch January 14, 2025 17:26
@theSuess theSuess added the refactor this PR refactors code without introducing functionality label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSuess theSuess theSuess approved these changes

@NissesSenap NissesSenap Awaiting requested review from NissesSenap NissesSenap is a code owner

@weisdd weisdd Awaiting requested review from weisdd weisdd is a code owner

@ishanjainn ishanjainn Awaiting requested review from ishanjainn ishanjainn is a code owner

@hubeadmin hubeadmin Awaiting requested review from hubeadmin hubeadmin is a code owner

@pb82 pb82 Awaiting requested review from pb82 pb82 is a code owner

Assignees
No one assigned
Labels
refactor this PR refactors code without introducing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baarsgaard @theSuess