fix(oncall): use selectors rather than refs #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexander-bauer
commented
Jan 10, 2025
alexander-bauer
commented
- fix(oncall): use claim name selectors for Integrations and EscalationChains
- fix(oncall): use selectors for OnCallShift membership in Schedules
…Chains When resources generated by previous versions of this subpackage refer to other resources, they use the resource's claim name as opposed to its (generated) resource name. This change replaces those references with selectors, which use the claim name in a `matchLabel` statement.
Duologic
reviewed
Jan 13, 2025
| escalation.new(id) | ||
| + escalation.spec.parameters.forProvider.escalationChainRef.withName(self.chainName) | ||
| + escalation.spec.parameters.forProvider.escalationChainSelector.withMatchLabels({ | ||
| 'crossplane.io/claim-name': this.chainName, |
There was a problem hiding this comment.
Theoretically, the same claim-name could exist in a different namespace, so this is probably not sufficient in the long run.
There was a problem hiding this comment.
I think this is a downside of keeping all the logic in jsonnet as opposed to using Crossplane Compositions.
There was a problem hiding this comment.
Why doesn't/won't escalationChainRef.withName() work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.