Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code for Auto detect barcode without user tap #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrigankdembla
Copy link

Hi ,

I saw an issue #94 according to which user asked to auto detect barcode without user interaction. So I have added switch/chechbox in the Main activity , which if selected will enable user to auto detect barcode and return its value.

I have made the changes in the following files by which if user wants to auto detect barcode, he/she can directly select switch/checkbox for auto detect on main activity and then barcode will be detected without tap and first detected barcode will be returned.

Please review the changes made in MainActivity,BarcodeCaptureActivity, BarcodeGraphicTracker and BarcodeTrackerFactory along with layout changes in activity_main.xml

Please review the changes made and tell me issues with it if any.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mrigankdembla
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@mrigankdembla
Copy link
Author

@claywilkinson please check this.. Thanks! :)

Copy link

@pchx-zz pchx-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes are appearing as new files -- are you sure you've included the right file paths in your commit?

@alibitek
Copy link

alibitek commented Nov 7, 2016

@mrigankdembla The changes are commited incorrectly at the root of the project: https://github.com/googlesamples/android-vision/tree/76f6fe5193ad114f787c2863ca976fe9a485ecbf . The files should be placed in the appropriate subdirectory.

@cluelin
Copy link

cluelin commented Dec 15, 2016

Thanks! it's working great!

@wanamr87
Copy link

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants