OCT-2327: Adds migration for nullifying uq score for sybil accounts #632
+65
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend/app/constants.py
Outdated
| @@ -961,6 +953,16 @@ | |||
| "0xe04f0abe1933499ff1d075fa10738ce7aad26b1a", | |||
| "0xadd7b1e78f0e59d96135c5240e1175d5a7dc210d", | |||
| "0x094b75eedf58a83af4d37694b7532691fb26570e", | |||
| "0xF3Ad97364bcCC3eA0582Ede58C363888f8C4ec85", | |||
There was a problem hiding this comment.
it should be on a GUEST_LIST or TIMEOUT_LIST?
There was a problem hiding this comment.
Addresses (list in task in linear) should be placed in timeout list & removed from guest list (if present)
There was a problem hiding this comment.
ok, got it; so on the TIMEOUT_LIST they should be lowercased AFAIR, now they are checksummed
| def upgrade(): | ||
| epoch = 6 | ||
| addresses = [ | ||
| "0xF3Ad97364bcCC3eA0582Ede58C363888f8C4ec85", |
There was a problem hiding this comment.
how are we gonna test it? shouldn't we place here Mati's address too?
There was a problem hiding this comment.
I'm waiting for Mati's addresses to add and add them here. We will test on UAT
adam-gf
changed the title
kgarbacinski
previously approved these changes
Jan 17, 2025
kgarbacinski
previously approved these changes
Jan 17, 2025
…-accounts-who-donated-to-zucity
kgarbacinski
approved these changes
Jan 17, 2025
housekeeper-bot
removed
the
request-approval
housekeeper-bot
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces UQ Score (the multiplier used for calculating matching founds) for found sybil accounts.
(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.
(2) Octant Areas & Test Cases.