Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCT-2126 Projects E2E #612

Merged
merged 12 commits into from
Jan 16, 2025
Merged

OCT-2126 Projects E2E #612

merged 12 commits into from
Jan 16, 2025

Conversation

aziolek
Copy link
Member

@aziolek aziolek commented Jan 2, 2025

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@aziolek aziolek self-assigned this Jan 2, 2025
@linear Linear
Copy link

linear bot commented Jan 2, 2025

OCT-2126 Projects E2E

@aziolek aziolek changed the base branch from develop to master January 2, 2025 14:16
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 2, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 2, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12583793496 failed 💥

@kgarbacinski
Copy link
Contributor

If you have issues with passing E2E due to the BE unstability, you may want to merge my branch: #611. Seems fixed but somebody else must review before merging with develop ✌️

housekeeper-bot
housekeeper-bot requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12583793496 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 10, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 11, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12717725797 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 13, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12749098842 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 13, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12757006322 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 14, 2025
@aziolek aziolek marked this pull request as ready for review January 14, 2025 10:39
@aziolek aziolek requested a review from jmikolajczyk January 14, 2025 10:39
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12765248741 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 14, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 14, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12769930328 failed 💥

housekeeper-bot
housekeeper-bot requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12769930328 failed 💥

housekeeper-bot
housekeeper-bot requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12769930328 failed 💥

housekeeper-bot
housekeeper-bot requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12769930328 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 15, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 15, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12787786353 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 15, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 15, 2025
housekeeper-bot
housekeeper-bot requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12792055534 failed 💥

@aziolek aziolek added the request-approval Request approval from the Housekeeper label Jan 15, 2025
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Jan 15, 2025
housekeeper-bot
housekeeper-bot approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12796788050 passed 🎉

@aziolek aziolek merged commit 91d4764 into master Jan 16, 2025
47 checks passed
@aziolek aziolek deleted the test/oct-2126-e2e-projects branch January 16, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@jmikolajczyk jmikolajczyk jmikolajczyk approved these changes

Assignees

@aziolek aziolek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aziolek @kgarbacinski @jmikolajczyk @housekeeper-bot