OCT-2282: Lowering the db connection pool size & adding settings for it #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgarbacinski
previously approved these changes
Dec 18, 2024
housekeeper-bot
removed
the
request-approval
housekeeper-bot
requested changes
Dec 18, 2024
housekeeper-bot
removed
the
request-approval
housekeeper-bot
approved these changes
Dec 18, 2024
kgarbacinski
approved these changes
Dec 18, 2024
adam-gf
deleted the
adam/oct-2282-align-the-pool-size-of-db-connection-to-avoid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To better handle the pool size of postgres we lowered the pool size from 100 and moved params to dedicated config.
The issue probably is due to the fact that pg has (default) 100 connection and pool size of sqlalchemy was equal to it, causing overflows / connection drops because of reached limit.