Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX]: favicon #584

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[HOTFIX]: favicon #584

merged 1 commit into from
Dec 11, 2024

Conversation

jmikolajczyk
Copy link
Contributor

Description

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@jmikolajczyk jmikolajczyk self-assigned this Dec 10, 2024
@jmikolajczyk jmikolajczyk requested a review from aziolek December 10, 2024 14:12
@aziolek aziolek added the request-approval Request approval from the Housekeeper label Dec 10, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Dec 10, 2024
housekeeper-bot
housekeeper-bot requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12258251286 failed 💥

housekeeper-bot
housekeeper-bot requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12258251286 failed 💥

housekeeper-bot
housekeeper-bot approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #12258251286 passed 🎉

@jmikolajczyk jmikolajczyk merged commit 8752909 into master Dec 11, 2024
47 checks passed
@jmikolajczyk jmikolajczyk deleted the hotfix/favicon branch December 11, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housekeeper-bot housekeeper-bot housekeeper-bot approved these changes

@aziolek aziolek aziolek approved these changes

Assignees

@jmikolajczyk jmikolajczyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmikolajczyk @aziolek @housekeeper-bot